[FFmpeg-devel] port mplayer eq filter to libavfilter

[William Yu]

2010/12/1 Ronald S. Bultje <rsbultje at gmail.com>:
> Hi,
>
> On Tue, Nov 30, 2010 at 4:10 AM, William Yu <genwillyu at gmail.com> wrote:
>> 2010/11/30 Ronald S. Bultje <rsbultje at gmail.com>:
>>> Hi,
>>>
>>> On Mon, Nov 29, 2010 at 10:57 AM, William Yu <genwillyu at gmail.com> wrote:
>>>> 2010/11/26 Ronald S. Bultje <rsbultje at gmail.com>:
>>>>> On Fri, Nov 26, 2010 at 9:38 AM, William Yu <genwillyu at gmail.com> wrote:
>>>>>> 2010/11/25 Ronald S. Bultje <rsbultje at gmail.com> wrote:
>>>>>>> On Thu, Nov 25, 2010 at 4:27 AM, William Yu <genwillyu at gmail.com> wrote:
>>>[..]
> Looking almost good. Now, it doesn't work on x86-64 yet because you're
> using a combination of size-specific calls and general registers:
>
>> ? ? ? ? "incl %0 \n\t"
>
> Should be inc
>
>> ? ? ? ? "addl %5, %0 \n\t"
>
> Should be add.
>
> Can anyone enlighten me what the "+m"(h) and "m"(step) do? Doing
> "+m"(h) -> "+r"(h) has no effect, and doing the same for step causes a
> compilation failure, probably because register size of int isn't the
> same as for a pointer, so add destptr, step fails. But other than
> that, what's the difference?
>

I have using macro OPSIZE and REG_x to replace size-specifically call
and generally registers.
Is my understanding right?

patch is updated. Please review it.

> Ronald
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vf_eq.diff
Type: application/octet-stream
Size: 13070 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101201/a2c911b0/attachment.obj>