[FFmpeg-devel] [PATCH] Port gradfun to libavfilter (GCI)

[Ronald S. Bultje]

Hi,

On Tue, Nov 30, 2010 at 10:00 PM, Nolan L <nol888 at gmail.com> wrote:
> On Tue, Nov 30, 2010 at 7:27 PM, Nolan L <nol888 at gmail.com> wrote:
>> Pushing a third revision of the code, addressing missing documentation
>> (mostly) and slight code changes related to confusing macros.
>
> Purely aesthetic change regarding a confusing segment of code. Seems as if
> this was the only complaint, so I'm creating a new revision for that one
> change.
[..]
> -void ff_gradfun_filter_line_ssse3(uint8_t *dst, uint8_t *src, uint16_t *dc, int width, int thresh, const uint16_t *dithers)
> -{
> -#if HAVE_SSSE3

The HAVE_ext should probably be outside the function. The compiler
should eliminate the assignment of a symbol in the init function if
HAVE_ext is zero (that's called dead code elimination), so that the
function is then unused anyway.

Otherwise looks good, except for that weird start at the top of the
SSSE3 function but I guess I don't quite know how to fix that.

Ronald