[FFmpeg-devel] [PATCH] RTP depacketizer for QCELP

[Stefano Sabatini]

On date Wednesday 2010-12-01 12:11:59 +0200, Martin Storsj? encoded:
> On Wed, 1 Dec 2010, Stefano Sabatini wrote:
> 
> > On date Monday 2010-11-29 19:19:02 +0200, Martin Storsj? encoded:
> 
> > > +    if (interleave_index > interleave_size) {
> > > +        av_log(ctx, AV_LOG_ERROR, "Invalid interleave index %d/%d\n",
> > > +                                   interleave_index, interleave_size);
> > > +        return AVERROR_INVALIDDATA;
> > 
> > AVERROR_INVALIDDATA is deprecated -> AVERROR(INVALIDDATA).
> 
> I guess you mean AVERROR(EINVAL)?
> 
> And why is it deprecated? In libavutil/error.h, I see a definition of 
> AVERROR_INVALIDDATA for both the current and future major versions.

Sorry I was wrong, AVERROR_INVALIDDATA can be used even if the current
definition is equivalent to that of AVERROR(EINVAL), which is wrong,
on the other hand changing it at the next major bump will cause a
break of all the libraries depending on libavutil. So while the issue
is not fixed it is just safe to use AVERROR_INVALIDDATA for now.
-- 
FFmpeg = Faithless and Friendly Maxi Programmable Evil Geisha