[FFmpeg-devel] [PATCH] Remove global mm_flags variable

Alex Converse alex.converse
Tue Aug 31 04:15:55 CEST 2010


2010/8/30 M?ns Rullg?rd <mans at mansr.com>:
> Jason Garrett-Glaser <darkshikari at gmail.com> writes:
>
>> On Mon, Aug 30, 2010 at 2:54 PM, Alex Converse <alex.converse at gmail.com> wrote:
>>> On Mon, Aug 23, 2010 at 7:31 PM, Mans Rullgard <mans at mansr.com> wrote:
>>>> ---
>>>> ?libavcodec/arm/dsputil_iwmmxt.c ? ?| ? ?3 ++-
>>>> ?libavcodec/dsputil.h ? ? ? ? ? ? ? | ? ?9 +--------
>>>> ?libavcodec/h263dec.c ? ? ? ? ? ? ? | ? ?2 +-
>>>> ?libavcodec/ppc/dsputil_ppc.c ? ? ? | ? ?4 ----
>>>> ?libavcodec/ppc/mpegvideo_altivec.c | ? ?2 +-
>>>> ?libavcodec/x86/dnxhd_mmx.c ? ? ? ? | ? ?2 +-
>>>> ?libavcodec/x86/dsputil_mmx.c ? ? ? | ? ?6 ++----
>>>> ?libavcodec/x86/dsputilenc_mmx.c ? ?| ? ?2 ++
>>>> ?libavcodec/x86/h264dsp_mmx.c ? ? ? | ? ?2 +-
>>>> ?libavcodec/x86/motion_est_mmx.c ? ?| ? ?2 ++
>>>> ?libavcodec/x86/mpegaudiodec_mmx.c ?| ? ?2 +-
>>>> ?libavcodec/x86/mpegvideo_mmx.c ? ? | ? ?2 ++
>>>> ?libavcodec/x86/snowdsp_mmx.c ? ? ? | ? ?2 +-
>>>> ?libavcodec/x86/vc1dsp_mmx.c ? ? ? ?| ? ?2 +-
>>>> ?libavcodec/x86/vp8dsp-init.c ? ? ? | ? ?2 +-
>>>> ?15 files changed, 19 insertions(+), 25 deletions(-)
>>>>
>>>
>>> I think it's about time to revert this. It's been a week and nobody
>>> has managed to fix it.
>>
>> Agreed; I can't come up with a good solution, so I endorse a revert.
>
> Where is the problem? ?Nobody uses ffmpeg on non-mmx hardware, and if
> someone were to insist on doing that, it is trivial to build it
> without mmx.
>

Problem 1:
If you specify a piece of non-MMX hardware as the CPU name you now get
a build that requires MMX.

Problem 2:
Some distros still seem to specify non MMX hardware in tehir minimum
system requirement eg
http://docs.fedoraproject.org/en-US/Fedora/13/html/Release_Notes/index.html#sect-Release_Notes-Hardware_Requirements



More information about the ffmpeg-devel mailing list