[FFmpeg-devel] [PATCH 1/1] Reimplement ff_img_copy_plane() as av_img_copy_plane() in libavcore, and deprecate the old function.

[Michael Niedermayer]

On Thu, Aug 26, 2010 at 02:27:27AM +0200, Stefano Sabatini wrote:
> On date Thursday 2010-08-26 00:44:12 +0200, Michael Niedermayer encoded:
[...]

> > if nothing outside needs it then no need to make it public and as is
> > the param should be renamed

after your patch it definitly is used outside.


> 
> Updated, regards.


[...]
> --- a/libavcodec/dsputil.c
> +++ b/libavcodec/dsputil.c
> @@ -27,6 +27,7 @@
>   * DSP utils
>   */
>  
> +#include "libavcore/internal.h"
>  #include "avcodec.h"
>  #include "dsputil.h"
>  #include "simple_idct.h"
> @@ -4466,7 +4467,7 @@ av_cold void dsputil_init(DSPContext* c, AVCodecContext *avctx)
>      c->sv_fmul_scalar[0] = sv_fmul_scalar_2_c;
>      c->sv_fmul_scalar[1] = sv_fmul_scalar_4_c;
>  
> -    c->shrink[0]= ff_img_copy_plane;
> +    c->shrink[0]= ff_copy_image_plane;
[...]
> --- a/libavcore/imgutils.c
> +++ b/libavcore/imgutils.c
> @@ -21,6 +21,7 @@
>   * misc image utilities
>   */
>  
> +#include "internal.h"
>  #include "imgutils.h"
>  #include "libavutil/pixdesc.h"
>  
> @@ -120,3 +121,16 @@ int av_check_image_size(unsigned int w, unsigned int h, int log_offset, void *lo
>      av_log(&imgutils, AV_LOG_ERROR, "Picture size %ux%u is invalid\n", w, h);
>      return AVERROR(EINVAL);
>  }
> +
> +void ff_copy_image_plane(uint8_t       *dst, int dst_linesize,
> +                         const uint8_t *src, int src_linesize,
> +                         int bytewidth, int height)
> +{
> +    if (!dst || !src)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100826/8755075a/attachment.pgp>