[FFmpeg-devel] A64 codec development

Måns Rullgård mans
Thu Aug 26 15:16:26 CEST 2010


Over the last few days, there has been a flurry of commits to an "a64"
codec.  This work is being done by a new developer without any review
whatsoever.  While I do not have reason to cast doubt on the general
competence of the developer, Tobias, it is clear he is not accustomed
to our style and way of working.

Thus I ask, why is this work being committed directly to svn without
review?  Why are patches not posted as is normal for work of this
type?  If the developer wants to work against a repository (something
I tend to recommend), I would rather suggest using github or another
free service rather than committing unreviewed code directly to the
master svn.  That is what the rest of us do.

I believe we all agree code reviews are good.  Everybody makes
mistakes once in a while, and routine reviews catch many of these
before any harm is done.  Allowing unreviewed code into main svn
increases the risk of an exploit finding its way through, which would
ultimately tarnish the reputation of FFmpeg as a whole, and rightly so.

-- 
M?ns Rullg?rd
mans at mansr.com



More information about the ffmpeg-devel mailing list