[FFmpeg-devel] Fix VP3 IDCT on Win64

[Måns Rullgård]

Loren Merritt <lorenm at u.washington.edu> writes:

> On Thu, 26 Aug 2010, Reimar D?ffinger wrote:
>> On Wed, Aug 25, 2010 at 08:43:25PM -0400, Ronald S. Bultje wrote:
>>>
>>> Those will stay inline of course. If an issue arises where we really
>>> need multiple (>6) XMM registers in inline functions (which I can
>>> honestly not imagine), then we'll think about a solution then and
>>> there.
>>
>> The solution is easy: only add the clobbers for compilers where they
>> are supported (I assume this was the issue on Win32/BSD? You never
>> said _what_ the problem was). This can be tested in configure.
>> And you'll have to specify the clobbers for inline functions even
>> for a single XMM register and even for Linux, it's just unreasonable
>> to hope that the compiler will never place some float stuff in a
>> bad location, particularly with global optimization enabled.
>
> Do you plan to add an emms at the end of every mmx function?

A problem does not go away by itself, no matter how unpleasant the cure.

-- 
M?ns Rullg?rd
mans at mansr.com