[FFmpeg-devel] [PATCH] Fix return value for incomplete H264 frame packets

Pásztor Szilárd don
Wed Aug 25 15:24:53 CEST 2010


Michael Niedermayer:
> we havent defined what the flags mean, how can any decoder set them if there
> is no clear definition.

Ok then I'll wait i think. I'm not familiar with the code enough to be able
to cover all possible cases for these flags.

> i think you need to read the existing code and need to use clear language
> "this problem" and the like without ever making any attempt at explaining
> what that would be is rather useless.

"this problem" refers to the problem what this thread is all about.
That is, when an incoming h264 packet contains a non-displayable field only,
players can't know that they have to re-call the decoder with more data
immediately, because not enough information is exported to them.

> and repeat_pict refers to outputed pictures, they by definition cannot be
> first-field-only so that case cannot be needed

And that's exactly what I'm talking about, that's why repeat_pict can't be
used to indicate the first-field case, unless hacking a -1 value into it
which is ugly and would probably break many things.

          ------------------------------------------------------------
          |  Prevent accidents on the roads! Drive on the pavement.  |
          ------------------------------------------------------------



More information about the ffmpeg-devel mailing list