[FFmpeg-devel] [PATCH] Remove global mm_flags variable

Reinhard Tartler siretart
Wed Aug 25 08:25:20 CEST 2010


On Tue, Aug 24, 2010 at 21:44:55 (CEST), Michael Niedermayer wrote:

> On Tue, Aug 24, 2010 at 10:39:30PM +0300, Ivan Kalvachev wrote:
>> On 8/24/10, Mans Rullgard <mans at mansr.com> wrote:
>> > -
>> > -#define emms_c() \
>> > -{\
>> > -    if (mm_flags & FF_MM_MMX)\
>> > -        emms();\
>> > -}
>> > +#define emms_c() emms()
>> 
>> Michael, are you really OK with that change?
>> The result would be illegal instruction on all pre-MMX CPUs.
>
> who still uses these?

I remember pretty prompt bugreports in both debian and ubuntu regarding
non-mmx capable CPUs.

Would that check be acceptable with --enable-runtime-cpudetect?


-- 
Gruesse/greetings,
Reinhard Tartler, KeyID 945348A4




More information about the ffmpeg-devel mailing list