[FFmpeg-devel] [PATCH] move diag4 VP6 filter from DSPContext to VP56DSPContext

[Måns Rullgård]

"Ronald S. Bultje" <rsbultje at gmail.com> writes:

> Hi,
>
> part of the "let's make dsputil smaller" department. make
> fate-ea-vp60, fate-vp6a and fate-vp5 pass after this patch on OSX.
>
> Ronald
>
> Index: libavcodec/x86/Makefile
> ===================================================================
> --- libavcodec/x86/Makefile	(revision 24909)
> +++ libavcodec/x86/Makefile	(working copy)
> @@ -29,11 +29,13 @@
>  MMX-OBJS-$(CONFIG_VP3_DECODER)         += x86/vp3dsp_mmx.o              \
>                                            x86/vp3dsp_sse2.o
>  MMX-OBJS-$(CONFIG_VP5_DECODER)         += x86/vp3dsp_mmx.o              \
> -                                          x86/vp3dsp_sse2.o
> +                                          x86/vp3dsp_sse2.o             \
> +                                          x86/vp56dsp-init.o
>  MMX-OBJS-$(CONFIG_VP6_DECODER)         += x86/vp3dsp_mmx.o              \
>                                            x86/vp3dsp_sse2.o             \
>                                            x86/vp6dsp_mmx.o              \
> -                                          x86/vp6dsp_sse2.o
> +                                          x86/vp6dsp_sse2.o             \
> +                                          x86/vp56dsp-init.o

Please use _ rather than - in filenames.  There's no actual advantage
one way or the other, but I like consistency.  Also, that file is
missing from the patch.

> Index: libavcodec/vp6dsp.c
> ===================================================================
> --- libavcodec/vp6dsp.c	(revision 24909)
> +++ libavcodec/vp6dsp.c	(working copy)
> @@ -22,7 +22,7 @@
>   */
>  
>  #include "libavutil/common.h"
> -#include "dsputil.h"
> +#include "vp56dsp.h"

\o/

Rest looks OK to me.

-- 
M?ns Rullg?rd
mans at mansr.com