[FFmpeg-devel] [PATCH] Fix return value for incomplete H264 frame packets

Laurent Aimar fenrir
Mon Aug 23 13:15:41 CEST 2010


On Mon, Aug 23, 2010 at 10:41:27AM +0000, Carl Eugen Hoyos wrote:
> P?sztor Szil?rd <don <at> tricon.hu> writes:
> 
> > attached is a small but very useful change to the h264 decoder. EAGAIN as
> > return value enables players to recognize if they supplied a H264 packet with
> > only the first field in it, so that they can re-call the decoder with the
> > second field, staying in sync.
> 
> I believe I already explained (on mplayer-dev-eng) that this patch makes ffmpeg
> print one warning message for every second PAFF field, so I don't think it is
> acceptable as-is.
 It will also make VLC print an error in the same case, while it is working
perfectly fine with the current code.
 Unless I misunderstood the current code, avcodec will consume the first field,
properly decode it and return no pictures and no errors. If so, it seems the
right behavior to me.

Regards,

-- 
fenrir




More information about the ffmpeg-devel mailing list