[FFmpeg-devel] [PATCH] add truemotion1 fate2 tests

[Reimar Döffinger]

On Sun, Aug 22, 2010 at 03:26:50PM +0100, M?ns Rullg?rd wrote:
> Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:
> > However I guess it could be done more "properly" as in attached patch,
> > if that's maybe a useful improvement?
> > (without the ref files this time).
> >
> > Index: Makefile
> > ===================================================================
> > --- Makefile	(revision 24867)
> > +++ Makefile	(working copy)
> > @@ -277,8 +277,9 @@
> >  
> >  ifdef SAMPLES
> >  FATE += $(FATE_TESTS)
> > +FATE_ALL = $(FATE) $(DISABLED_FATE_TESTS)
> >  else
> > -fate2 $(FATE_TESTS):
> > +fate2 $(FATE_TESTS) $(DISABLED_FATE_TESTS):
> >  	@echo "SAMPLES not specified, cannot run FATE"
> >  endif
> >  
> > @@ -287,7 +288,7 @@
> >  fate: $(FATE)
> >  fate2: $(FATE2_TESTS)
> >  
> > -$(FATE): ffmpeg$(EXESUF) $(FATE_UTILS:%=tests/%$(HOSTEXESUF))
> > +$(FATE_ALL): ffmpeg$(EXESUF) $(FATE_UTILS:%=tests/%$(HOSTEXESUF))
> >  	@echo "TEST    $(@:fate-%=%)"
> >  	$(Q)$(SRC_PATH)/tests/fate-run.sh $@ "$(SAMPLES)" "$(TARGET_EXEC)" "$(TARGET_PATH)" '$(CMD)' '$(CMP)' '$(REF)' '$(FUZZ)'
> 
> I see no need for this.  Just add the test and be done with it.

Ok, just though it would be nice to have in case we ever have a test
we can't fix properly in the near time, but I guess currently there
really isn't much of point.