[FFmpeg-devel] [PATCH] Add libavsequencer.

[Sebastian Vater]

Ronald S. Bultje a ?crit :
> Hi,
>
> On Wed, Aug 18, 2010 at 5:58 PM, Stefano Sabatini
> <stefano.sabatini-lala at poste.it> wrote:
>   
>> So in the end I suggest this course of action: apply the lavseq patch,
>> *or* if we want to add more stuff to it before to commit it, then
>> maybe we should focus on the BSS. Once that's ready, we can create
>> lavseq *and* immediatly commit the BSS definition.
>>     
>
> I don't want anything committed until I've seen all patches required
> for TCM playback posted to ffmpeg-devel so we can judge whether each
> component is actually necessary.
>   

Could you clarify a bit? What you exactly mean by all patches?
To get *full* TCM playback you actually need most of what is in my
github, which would be quite large.

Which would means the whole player.[ch] files which is quite large, also
at least the lq_mixer.c which is also very large (but as already
mentioned this one can be simplified at lot regarding code lines by
using #define stuff).

> I don't want duplicate code, I don't want overly complicated code and
> I don't want overdesigned code. I want exactly that code necessary for
> TCM playback. Nothing more. Those patches, we will review together,
> removing things that are unneeded/unused, removing code available
> already elsewhere in FFmpeg, and simplifying it to the best of our
> ability. Once that process is done, we can commit the individual
> parts.
>   

Well for basic TCM playback that would be exactly the code which I
commited to my github, for full support. The only exception would be the
null mixer, though.

Maybe if we want to integrate something to main SVN as fast as possible,
we should use Vitor's approach, i.e. get transcoding to work at first,
which as already said, would just require BSS and a (de-)muxer pair.

But for full playback, there's no way around about the whole player.[hc]
and at least one mixer. But for the mixer, we could start with a simple
8-bit mono only mixer, which would be sufficient enough to get at least
TCMs working converting from plain old amiga MOD and S3M (which also had
only 8-bit files).

> Committing one part without knowing how the next part uses it is about
> the worst design nightmare possible.
>   

Yes, that's true!

-- 

Best regards,
                   :-) Basty/CDGS (-: