[FFmpeg-devel] [PATCH] Add AVC EOS tag to H264-encoded FLV files

[Michael Niedermayer]

On Thu, Aug 12, 2010 at 10:27:28PM -0700, Thierry Foucu wrote:
> On Thu, Aug 5, 2010 at 1:33 PM, Baptiste Coudurier <
> baptiste.coudurier at gmail.com> wrote:
> 
> > On 08/05/2010 09:48 AM, Thierry Foucu wrote:
> > >
> > > [...]
> >
> >
> >> +static void put_avc_eos_tag(ByteIOContext *pb, unsigned ts) {
> >> +    put_byte(pb, FLV_TAG_TYPE_VIDEO);
> >> +    put_be24(pb, 5);  /* Tag Data Size */
> >> +    put_be24(pb, ts);  /* lower 24 bits of timestamp in ms*/
> >> +    put_byte(pb, (ts>>  24)&  0x7F);  /* MSB of ts in ms*/
> >> +    put_be24(pb, 0);  /* StreamId = 0 */
> >> +    put_byte(pb, 23);  /* ub[4] FrameType = 1, ub[4] CodecId = 7 */
> >> +    put_byte(pb, 2);  /* AVC end of sequence */
> >> +    put_be24(pb, 0);  /* Always 0 for AVC EOS. */
> >> +    put_be32(pb, 16);  /* Size of FLV tag */
> >> +}
> >> +
> >>  static void put_amf_double(ByteIOContext *pb, double d)
> >>  {
> >>      put_byte(pb, AMF_DATA_TYPE_NUMBER);
> >> @@ -309,7 +321,16 @@
> >>
> >>      ByteIOContext *pb = s->pb;
> >>      FLVContext *flv = s->priv_data;
> >> +    int i;
> >>
> >> +    /* Add EOS tag */
> >> +    for (i = 0; i<  s->nb_streams; i++) {
> >> +        AVCodecContext *enc = s->streams[i]->codec;
> >> +        if (enc->codec_type == CODEC_TYPE_VIDEO&&  enc->codec_id ==
> >> CODEC_ID_H264) {
> >> +            put_avc_eos_tag(pb, flv->duration);
> >> +        }
> >>
> >
> > flv->duration is the pts, this is wrong, you must write the dts in the
> > timestamp field.
> >
> >
> Ok, what about this one:

probably ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Complexity theory is the science of finding the exact solution to an
approximation. Benchmarking OTOH is finding an approximation of the exact
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100818/4b8e9289/attachment.pgp>