[FFmpeg-devel] [PATCH] Add support for sndio to libavdevice

Aurelien Jacobs aurel
Wed Aug 18 11:08:30 CEST 2010


On Tue, Aug 17, 2010 at 05:58:54PM -0400, Brad wrote:
> On Mon, Aug 02, 2010 at 07:42:28PM -0400, Brad wrote:
> > sndio is a relatively new audio API utilized by OpenBSD.
> > 
> > Below is a patch to add sndio playback and record support
> > to FFmpeg.
> > 
> > I believe I have touched everything that needs updating
> > including documentation such as the recently added
> > indevs.texi and outdevs.texi, but if not please let
> > me know.
> > 
> > The sndio code was written by Jacob Meuser <jakemsr sdf lonestar org>
> > 
> > Please provide any feedback.
> 
> And using the new AV_NE() macro.
> 
> [...]
> 
> Index: libavdevice/Makefile
> ===================================================================
> --- libavdevice/Makefile	(revision 24819)
> +++ libavdevice/Makefile	(working copy)
> @@ -17,6 +17,10 @@
>  OBJS-$(CONFIG_JACK_INDEV)                += jack_audio.o
>  OBJS-$(CONFIG_OSS_INDEV)                 += oss_audio.o
>  OBJS-$(CONFIG_OSS_OUTDEV)                += oss_audio.o
> +OBJS-$(CONFIG_SNDIO_INDEV)               += sndio-common.o \
> +                                            sndio-dec.o

This fits on a single line.
Also we generally don't use hyphen in file names (I know, alsa is an
exception :-( ). So it would probably be more consistent to use an
underscore instead.

Aurel



More information about the ffmpeg-devel mailing list