[FFmpeg-devel] [PATCH] Allow setting mode MONO in libmp3lame if the library is greater than 3.97

[Tomas Härdin]

On Tue, 2010-08-17 at 13:40 -0700, Thierry Foucu wrote:
> On Tue, Aug 17, 2010 at 1:20 PM, Michael Niedermayer <michaelni at gmx.at>wrote:
> 
> > On Tue, Aug 17, 2010 at 11:39:48AM -0700, Thierry Foucu wrote:
> > > 2010/8/16 M?ns Rullg?rd <mans at mansr.com>
> > >
> > > > Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:
> > > >
> > > > > On date Monday 2010-08-16 17:18:51 +0200, Michael Niedermayer
> > encoded:
> > > > >> On Fri, Aug 13, 2010 at 02:29:11PM -0700, Thierry Foucu wrote:
> > > > >> > On Fri, Aug 13, 2010 at 11:40 AM, Reimar D?ffinger <
> > > > Reimar.Doeffinger at gmx.de
> > > > >> > > wrote:
> > > > >> >
> > > > >> > > On Fri, Aug 13, 2010 at 10:00:39AM -0700, Thierry Foucu wrote:
> > > > >> > > > +    get_lame_version_numerical(&lame_version);
> > > > >> > > > +    if (lame_version.major <= 3 && lame_version.minor < 97) {
> > > > >> > >
> > > > >> > > I think that isn't quite right, it would do the wrong thing
> > > > >> > > for a (probably non-existent and not supported by us)
> > > > >> > > 2.99 version.
> > > > >> > >
> > > > >> >
> > > > >> > True.. Will send a new patch for this (after the follow up
> > > > >> > question will be answer)
> > > > >> >
> > > > >> >
> > > > >> > > Also do we really need to support the buggy older versions?
> > > > >> > >
> > > > >> >
> > > > >> >
> > > > >> > Up to you. I can remove the test and be done with it.
> > > > >> > What do the others dev think about it?
> > > > >>
> > > > >> i am in favor of such checks if and only if we have a volunteer to
> > > > maintain
> > > > >> them
> > > > >>
> > > > >> do we?
> > > > >
> > > > > I'm for adding a version check in configure, which avoids the use of
> > > > > an older version, as we do for other libraries (e.g. libx264,
> > > > > librtmp).
> > > >
> > > > How likely are old lame versions in the wild?  IOW, how old is the
> > > > latest bad version, and have major distros updated (to the extent they
> > > > ship lame at all)?
> > > >
> > > >
> > > Here is a patch which sets the mode based on stereo and it does not check
> > > the lame version.
> >
> > ok, but this needs a configure check to make sure lame is not too old
> >
> >
> I look at the ffmpeg configure, and i was thinking to use
> check_cpp_condition, however lame does include their version in the lame.h.
> The only way to get their version is to call some of their function which
> return a char*.
> 
> so not sure how to do the check in the configure unless adding another
> function specific to lame verification checking.
> 
> Any idea? suggestion?

Couldn't you have configure create a small programs that prints that
string, run it and parse and test the version number from the output?

/Tomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100818/8859ae6c/attachment.pgp>