[FFmpeg-devel] [PATCH 2/2] Add hflip filter.

Stefano Sabatini stefano.sabatini-lala
Tue Aug 17 14:00:53 CEST 2010

On date Monday 2010-08-16 21:33:56 +0100, M?ns Rullg?rd encoded:
> "Ronald S. Bultje" <rsbultje at gmail.com> writes:
> > Hi,
> >
> > On Mon, Aug 16, 2010 at 3:57 PM, Stefano Sabatini
> > <stefano.sabatini-lala at poste.it> wrote:
> >> My problem with dsputil is that:
> > [..]
> >
> > No, no dsputil. I want nothing to do with dsputil, and we all want to
> > kill it, I think (ask Mans).
> We want to trim it back to a reasonable size by splitting off parts to
> separate contexts.
> > We want a new, libavfilter-specific, AVHFlipVFilterDSPContext struct
> > in a file called libavfilter/whatever (and so on). If CPU-detection is
> > an issue (might still be in lavc), we can move that from lavc to
> > lavcore or so, but that really only becomes relevant once someone
> > starts writing optimizations. Have a look at lavc/vp8dsp.[ch] for an
> > example.
> If the operation required can be formulated in a generic way, it
> should be given a more generic name, but your point remains.  There is
> also no immediate need to optimise hflip to death.  I doubt it will be
> used all that much.  What we should do is make sure things which are
> in principle optimisable can be easily optimised should the need ever
> arise, i.e. keep separate things logically separated in the code.

Hi, I'll apply the patch this evening, then I'll see what I can do
about optimizations.

FFmpeg = Formidable & Foolish Mournful Philosofic Explosive Governor

More information about the ffmpeg-devel mailing list