[FFmpeg-devel] [PATCH] swscale-test: add md5 output

[Ramiro Polla]

On Mon, Aug 2, 2010 at 8:29 PM, Ramiro Polla <ramiro.polla at gmail.com> wrote:
> On Sat, Jul 31, 2010 at 7:47 PM, Vitor Sessak <vitor1001 at gmail.com> wrote:
>> On 08/01/2010 12:31 AM, Ramiro Polla wrote:
>>> On Sat, Jul 31, 2010 at 7:27 PM, Vitor Sessak<vitor1001 at gmail.com> ?wrote:
>>>> On 07/31/2010 11:10 PM, Ramiro Polla wrote:
>>>>> On Sun, Jul 25, 2010 at 9:54 PM, Michael Niedermayer<michaelni at gmx.at>
>>>>> ?wrote:
>>>>>> SSE of 123 does not implicate that there is no change to a previous SSE
>>>>>> of 123
>>>>>> and a change of CRC does tell nothing of the SSE
>>>>>
>>>>> For regression tests we want a checksum to be bitexact (I'll send a
>>>>> patch to add the bitexact flag to sws_flags later), and in this case
>>>>> the SSE doesn't matter.
>>>>
>>>> It does, because every time there is a patch that is expected to change
>>>> the
>>>> CRC (and thus update the reference output of the tests) it is easy to
>>>> know
>>>> if it improves or reduce the PSNR by just looking at the diff of the
>>>> reference file. That's the reason why "make test" prints also the
>>>> psnr/stddev.
>>>
>>> Hm, I was hoping that whenever the checksum changed, the dev would
>>> himself run swscale-test -sse...
>>
>> It is always clearer to see the stddev before and after the patch right
>> there in the diff in case the reviewer want to know...
>>
>>> So do you think it'd be best to always print out both checksum and sse?
>>
>> I think it is worth the few extra bytes per test.
>
> New patch attached.

New patch attached which takes into account pixel formats where
dstStride != dstW (like nv12).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: swscale-test-checksum2.diff
Type: application/octet-stream
Size: 1779 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100816/4cfc9f90/attachment.obj>