[FFmpeg-devel] [PATCH] Add support for sndio to libavdevice

Brad brad
Mon Aug 16 21:24:14 CEST 2010


On Monday 16 August 2010 14:44:27 M?ns Rullg?rd wrote:
> Diego Biurrun <diego at biurrun.de> writes:
> > On Sun, Aug 08, 2010 at 10:20:06PM +0100, M?ns Rullg?rd wrote:
> >> Brad <brad at comstyle.com> writes:
> >> > On Sunday 08 August 2010 03:37:32 Diego Biurrun wrote:
> >> >> Indentation is off.  How hard can it be to get this right?  Watch:
> >> >
> >> > How hard could it be to clean up the source code already in the tree
> >> > to not provide piss poor examples?
> >>
> >> You're not making any friends that way.
> >
> > Surely not, but after the third try of getting a (seemingly) simple
> > thing across, I do lose my patience.  The patch was also inconsistent
> > with itself in this regard, there was an instance of correct
> > indentation in another fil.
>
> I was addressing Brad, not you (Diego).  I'm as annoyed as anyone with
> people who copy the worst example they can find.

The obvious and biggest offender for various issues based on the feedback 
would be the OSS sound backend. Although I had looked at a few other random 
spots for various formatting inspiration with the feedback I had received, 
such as the long line wrapping. Fix the OSS backend first. I might be able to
track down the other files again and point them out.

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.




More information about the ffmpeg-devel mailing list