[FFmpeg-devel] [PATCH] Allow setting mode MONO in libmp3lame if the library is greater than 3.97

[Michael Niedermayer]

On Fri, Aug 13, 2010 at 02:29:11PM -0700, Thierry Foucu wrote:
> On Fri, Aug 13, 2010 at 11:40 AM, Reimar D?ffinger <Reimar.Doeffinger at gmx.de
> > wrote:
> 
> > On Fri, Aug 13, 2010 at 10:00:39AM -0700, Thierry Foucu wrote:
> > > +    get_lame_version_numerical(&lame_version);
> > > +    if (lame_version.major <= 3 && lame_version.minor < 97) {
> >
> > I think that isn't quite right, it would do the wrong thing
> > for a (probably non-existent and not supported by us)
> > 2.99 version.
> >
> 
> True.. Will send a new patch for this (after the follow up question will be
> answer)
> 
> 
> > Also do we really need to support the buggy older versions?
> >
> 
> 
> Up to you. I can remove the test and be done with it.
> What do the others dev think about it?

i am in favor of such checks if and only if we have a volunteer to maintain
them

do we?


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100816/9ace0524/attachment.pgp>