[FFmpeg-devel] [PATCH][issue2079] ffplay: segfault if coded video WxH dimension larger than desktop

[Mike Scheutzow]

Michael Niedermayer wrote:
> i see n patch in this thread nor a [patch] in the subj
> also dont forget our patch checklist patcheck and an explanation of
> why and how and what

These patches are for issue2079.

Multiple users have reported a segfault in ffplay when they attempt to 
play a high definition video stream.

The cause of the segfault is a buffer overrun when FFmpeg code is 
copying pixel data into a buffer allocated by SDL_CreateYUVOverlay. The 
behavior of SDL_CreateYUVOverlay is to allocate the requested size when 
possible, or the largest overlay size supported by the underlying video 
driver and hardware.

The problem is that the ffplay code assumes that a buffer of the 
requested size was allocated.

move-funcs-v1.patch moves two existing functions to avoid a forward 
declaration in the 2nd patch.

issue2079-avoid-segfault-v2.patch checks if SDL allocated a buffer 
smaller than requested, and exits the application with a message if it did.

tools/patcheck has been run on both patches.

-- 
Mike Scheutzow



-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: issue2079-avoid-segfault-v2.patch
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100815/47828b04/attachment.asc>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: move-funcs-v1.patch
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100815/47828b04/attachment.txt>