[FFmpeg-devel] [PATCH] Add libavsequencer.

Sebastian Vater cdgs.basty
Sat Aug 14 14:16:04 CEST 2010


Stefano Sabatini a ?crit :
> On date Friday 2010-08-13 22:53:30 +0200, Sebastian Vater encoded:
>   
>> The new library is meant to contain the sequencer multimedia features for
>> being able to playback modules and MIDI files in FFmpeg.
>>
>>     
> [...]
>   
>> diff --git a/libavsequencer/avsequencer.c b/libavsequencer/avsequencer.c
>> new file mode 100644
>> index 0000000..d43284f
>> --- /dev/null
>> +++ b/libavsequencer/avsequencer.c
>> @@ -0,0 +1,43 @@
>> +/*
>> + * Implement AVSequencer functions
>> + * Copyright (c) 2010 Sebastian Vater <cdgs.basty at googlemail.com>
>> + *
>> + * This file is part of FFmpeg.
>> + *
>> + * FFmpeg is free software; you can redistribute it and/or
>> + * modify it under the terms of the GNU Lesser General Public
>> + * License as published by the Free Software Foundation; either
>> + * version 2.1 of the License, or (at your option) any later version.
>> + *
>> + * FFmpeg is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
>> + * Lesser General Public License for more details.
>> + *
>> + * You should have received a copy of the GNU Lesser General Public
>> + * License along with FFmpeg; if not, write to the Free Software
>> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
>> + */
>> +
>> +#include "config.h"
>> +#include "avsequencer.h"
>> +
>> +/**
>> + * @file
>> + * Implement AVSequencer functions.
>> + */
>> +
>> +#include <libavutil/avutil.h>
>> +
>>     
>
>   
>> +unsigned avsequencer_version(void) {
>> +    return LIBAVSEQUENCER_VERSION_INT;
>> +}
>> +
>> +const char *avsequencer_configuration(void) {
>> +    return FFMPEG_CONFIGURATION;
>> +}
>> +
>> +const char *avsequencer_license(void) {
>> +#define LICENSE_PREFIX "libavsequencer license: "
>> +    return LICENSE_PREFIX FFMPEG_LICENSE + sizeof(LICENSE_PREFIX) - 1;
>> +}
>>     
>
> Nits:
> foo(...)
> {
>   ...
> }
>   

Just a question, I use foo(...) {
    ...
}

all over the AVSequencer code, should I fix that generally? If not, I'ld
like to keep that here to have a consistent style within AVSequencer.

> Looks OK otherwise to me, assuming that Micheal is OK with
> libavsequencer inclusion, note that libavsequencer is currently
> disabled by default. We can consider libavsequencer API unstable, and
> so don't worry too much about API/ABI breaks.
>
> I believe it's better to keep it integrated and disabled by default
> rather than keep it in an external repo, Sebastian will add piece by
> piece as review will go on.
>   

Nice, just added the reindentation patch for cmdutils.c and configure.

-- 

Best regards,
                   :-) Basty/CDGS (-:

-------------- next part --------------
A non-text attachment was scrubbed...
Name: lavseq-basic-indentation.patch
Type: text/x-patch
Size: 2435 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100814/f64cf455/attachment.bin>



More information about the ffmpeg-devel mailing list