[FFmpeg-devel] [patch]add mmsh protocol and extract common code for mmst.c
Thu Aug 12 19:26:38 CEST 2010
On Thu, Aug 12, 2010 at 7:14 AM, Ronald S. Bultje <rsbultje at gmail.com>wrote:
> On Mon, Aug 9, 2010 at 12:05 PM, zhentan feng <spyfeng at gmail.com> wrote:
> > #9 adds mmsh.c
> > +#define CHUNK_TYPE_DATA 0x4424
> > +#define CHUNK_TYPE_ASF_HEADER 0x4824
> > +#define CHUNK_TYPE_END 0x4524
> > +#define CHUNK_TYPE_STREAM_CHANGE 0x4324
> Do these mean anything? (If not, that's OK, just wondering...)
> You could consider making CHUNK_TYPE_* an enum.
the value has special meaning. I add comment for this.
I have fixed the code according to each reviewing item.
please see the new patch for mmsh.c
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 13476 bytes
Desc: not available
More information about the ffmpeg-devel