[FFmpeg-devel] [PATCH] lavfi audio framework

[S.N. Hemanth Meenakshisundaram]

> On date Wednesday 2010-08-11 06:54:59 -0700, S.N. Hemanth
> Meenakshisundaram encoded:
>> [...]
>> +
>> +typedef struct AVFilterBufferRefAudioProps
>> +{
>
> Nit: skip the newline, "{" on the same line as "struct
> AVFilterBufferRefAudioProps".

All the other structures have the newline. Is it ok to be inconsistent
with AVFilterBufferRefAudioProps alone.

>>
>>[...]
>> + */
>> +AVFilterBufferRef *avfilter_get_audio_buffer(AVFilterLink *link, int
>> perms,
>> +                                             int size, int64_t
>> channel_layout,
>> +                                             enum SampleFormat
>> sample_fmt, int planar);
>
> Why is the format required by avfilter_default_get_audio_buffer() and
> not by avfilter_default_get_video_buffer()?
>
> Also I wonder if we shouldn't rather have:
> AVFilterBufferRef *avfilter_default_get_audio_buffer(AVFilterLink *link,
> int perms, const AVFilterBufferRefAudioProps *props);
>
> otherwise we're going to break API whenever a new field is added to
> AVFilterBufferRefAudioProps.
>
> That's in the case there are valid reason to believe that new fields
> may be added, I cannot judge that right now. Michael?

Sample format is needed because bits per sample, number of channels and
planar/packed together decide linesizes and where the pointers to data of
each channel must point.

I can replace with audio props if necessary, please let me know.

Other nits fixed.

---
 doc/APIchanges         |    4 ++
 libavfilter/avfilter.c |   56 +++++++++++++++++++++++++++
 libavfilter/avfilter.h |   93 ++++++++++++++++++++++++++++++++++++++++++---
 libavfilter/defaults.c |   98
++++++++++++++++++++++++++++++++++++++++++++++++
 libavfilter/formats.c  |    3 +-
 5 files changed, 247 insertions(+), 7 deletions(-)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 397f21a0cea74f8c0a8e2805d6556a8fdb2ba755.diff
Type: text/x-patch
Size: 19207 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100811/5f554087/attachment.bin>