[FFmpeg-devel] [PATCH 2/3] ffmpeg: open encoders after decoders
Wed Aug 11 17:35:34 CEST 2010
On Wed, Aug 11, 2010 at 06:22:22PM +0200, Michael Niedermayer wrote:
> On Tue, Aug 10, 2010 at 10:39:37PM +0200, Aurelien Jacobs wrote:
> > On Tue, Aug 10, 2010 at 02:10:35PM +0200, Michael Niedermayer wrote:
> > > On Sun, Aug 08, 2010 at 02:26:57AM +0200, Aur?lien Jacobs wrote:
> > > > From: Aurelien Jacobs <aurel at gnuage.org>
> > > >
> > > > ---
> > > > ffmpeg.c | 46 +++++++++++++++++++++++-----------------------
> > > > 1 files changed, 23 insertions(+), 23 deletions(-)
> > >
> > > this should be unneeded, av_find_stream_info() should cause all the things
> > > to be set
> > It currently don't. So I've tried to force av_find_stream_info() to fill
> > the subtitle_header field with the attached patch. With this,
> > av_find_stream_info() indeed fills subtitle_header, but after it finishes
> > probing parameters, it calls avcodec_close() which effectively free the
> > subtitle_header buffer.
> > So after av_find_stream_info() call, subtitle_header is NULL again...
> > Any better alternative ?
> > To me it seems somewhat logical to initialize decoders before encoders.
> that might require changing applications and might be non trivial for some.
Indeed, I didn't thought about this :-(
Anyway, I still don't see any better solution...
And applications will have to be changed anyway, to copy subtitle_header
to the encoder context.
More information about the ffmpeg-devel