[FFmpeg-devel] [HACK] Remove MAX_STREAMS usages

Reimar Döffinger Reimar.Doeffinger
Tue Aug 10 15:43:53 CEST 2010


On Mon, Aug 09, 2010 at 11:46:41PM +0200, Aurelien Jacobs wrote:
> On Mon, Aug 09, 2010 at 11:23:20PM +0200, Reimar D?ffinger wrote:
> > On Mon, Aug 09, 2010 at 10:45:32PM +0200, Aurelien Jacobs wrote:
> > > @@ -1969,6 +1974,7 @@ static int rtsp_read_close(AVFormatContext *s)
> > >      ff_rtsp_close_streams(s);
> > >      ff_rtsp_close_connections(s);
> > >      ff_network_close();
> > > +    av_freep(&rt->real_setup_cache);
> > 
> > Maybe also set the other one to NULL as well?
> 
> This shouldn't be useful, but OK, for extra-safety.

I know, mostly suggested it for consistency.
Maybe we one day can automatically check that e.g. all pointers
are NULLed after close, which then would ensure all memleaks
should appear as "definitely lost" in valgrind or something
like that.
Might never happen I admit, just seemed like a case of
"more likely to do good than bad".



More information about the ffmpeg-devel mailing list