[FFmpeg-devel] [PATCH] Add support for sndio to libavdevice

[Diego Biurrun]

On Mon, Aug 09, 2010 at 07:01:50PM +0200, Aurelien Jacobs wrote:
> On Sun, Aug 08, 2010 at 10:19:41PM +0100, M?ns Rullg?rd wrote:
> > Diego Biurrun <diego at biurrun.de> writes:
> > 
> > > On Thu, Aug 05, 2010 at 08:21:21AM +0100, M?ns Rullg?rd wrote:
> > >> Diego Biurrun <diego at biurrun.de> writes:
> > >> 
> > >> > On Mon, Aug 02, 2010 at 07:42:28PM -0400, Brad wrote:
> > >> >> 
> > >> >> Please provide any feedback.
> > >> >
> > >> > Here you go..
> > >> >
> > >> >> --- Changelog	(revision 24666)
> > >> >> +++ Changelog	(working copy)
> > >> >> @@ -27,9 +27,9 @@
> > >> >>  - SubRip subtitle file muxer and demuxer
> > >> >>  - Chinese AVS encoding via libxavs
> > >> >>  - ffprobe -show_packets option added
> > >> >> +- sndio support for playback and record
> > >> >>  
> > >> >>  
> > >> >> -
> > >> >>  version 0.6:
> > >> >
> > >> > The empty line was there on purpose.
> > >> 
> > >> Care to tell us _what_ that purpose is?
> > >
> > > Readability, what else?
> > 
> > I fail to see how 3 blank lines are more readable than 2.
> 
> Agree. To me, 2 blank lines are more readable than 3.
> I always wondered why those 3 lines were added. I thought it was to
> comply to some stupid "standard", but certainly not for readability.

3 lines are simply a larger and clearer offset than 2.  I will not
waste my time fighting about this.  If you are hellbent on 2, have
your way...

> Moreover, many patch senders tend to naturally remove the third line,
> only to receive a laconic email from diego asking to resend the patch
> without this change. So this additionnal line adds some useless
> maintenance and patch submission burden.

I hold a bet that the same will happen with 2 lines, but we shall find
out...

> So I propose we just switch back to 2 lines, and end up this madness.

Go right ahead, but please consistently fix the complete file.

Diego