[FFmpeg-devel] [HACK] Remove MAX_STREAMS usages
Tue Aug 10 00:58:06 CEST 2010
On Mon, Aug 09, 2010 at 06:48:59PM -0400, Ronald S. Bultje wrote:
> On Mon, Aug 9, 2010 at 4:45 PM, Aurelien Jacobs <aurel at gnuage.org> wrote:
> > On Mon, Aug 09, 2010 at 03:46:29PM -0400, Ronald S. Bultje wrote:
> >> On Mon, Aug 9, 2010 at 2:48 PM, Reimar D?ffinger
> >> <Reimar.Doeffinger at gmx.de> wrote:
> >> > On Mon, Aug 09, 2010 at 01:20:57PM -0400, Ronald S. Bultje wrote:
> >> >> > + ? ?rt->real_setup_cache = av_mallocz(2 * s->nb_streams * sizeof(*rt->real_setup_cache));
> >> >>
> >> >> Why 2 * ..?
> >> >
> >> > Because it is also used as a temporary variable to replace
> >> > a on-stack variable.
> >> > It might be more readable to add a second pointer to the context instead though.
> >> I don't mind the single alloc, but two pointers would make this a
> >> little more understandable...
> > No problem. Here it is.
> > I only tested the RDT and RTSP changes by playing a rtps:// url with
> > ffplay. I guess that's enough ?
> Try rtsp://22.214.171.124/farm/126.96.36.199/encoder/wrnengus.rm
Tested with this stream, it's working fine. Thanks.
More information about the ffmpeg-devel