[FFmpeg-devel] [HACK] Remove MAX_STREAMS usages

Aurelien Jacobs aurel
Mon Aug 9 22:45:32 CEST 2010


On Mon, Aug 09, 2010 at 03:46:29PM -0400, Ronald S. Bultje wrote:
> Hi,
> 
> On Mon, Aug 9, 2010 at 2:48 PM, Reimar D?ffinger
> <Reimar.Doeffinger at gmx.de> wrote:
> > On Mon, Aug 09, 2010 at 01:20:57PM -0400, Ronald S. Bultje wrote:
> >> > + ? ?rt->real_setup_cache = av_mallocz(2 * s->nb_streams * sizeof(*rt->real_setup_cache));
> >>
> >> Why 2 * ..?
> >
> > Because it is also used as a temporary variable to replace
> > a on-stack variable.
> > It might be more readable to add a second pointer to the context instead though.
> 
> I don't mind the single alloc, but two pointers would make this a
> little more understandable...

No problem. Here it is.

I only tested the RDT and RTSP changes by playing a rtps:// url with
ffplay. I guess that's enough ?

Aurel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: max_stream_rtsp.diff
Type: text/x-diff
Size: 2884 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100809/a38f9212/attachment.diff>



More information about the ffmpeg-devel mailing list