[FFmpeg-devel] [PATCH] configure libvpx check version of decoder only

Diego Biurrun diego
Sun Aug 8 10:50:38 CEST 2010


On Sun, Aug 08, 2010 at 02:06:50AM +0200, Diego Biurrun wrote:
> On Tue, Aug 03, 2010 at 07:38:56PM -0700, Frank Barchard wrote:
> > On Sat, Jul 31, 2010 at 9:21 AM, Ronald S. Bultje <rsbultje at gmail.com>wrote:
> > 
> > > What you should do:
> > > (A-B of above remain in place)
> > > C) if fflibvpxdec is enabled, check for decoder symbols.
> > > D) if fflibvpxenc is enabled, check for encoder symbols.
> > > E) you could arguably say that if someone has encoder-only or
> > > decoder-only libvpx installed, he would want only that one enabled in
> > > ffmpeg. Therefore, Die if C AND D fail. If C OR D fail, disable the
> > > failing fflibvpxenc/dec wrapper.
> > 
> > Done.
> > If you enable only the encoder or decoder, just those symbols are checked.
> > By default both are checked and will die if you have a decode only or encode
> > only library.
> 
> Thanks, applied.

10l of Cola to Frank for being a high-paid Google engineer that does
not test his patches.

100l of Cola to me for applying patches from Mr Barchard minutes before
going to sleep with insufficient testing.

Diego



More information about the ffmpeg-devel mailing list