[FFmpeg-devel] [patch]add mmsh protocol and extract common code for mmst.c

zhentan feng spyfeng
Fri Aug 6 18:44:39 CEST 2010


On Wed, Aug 4, 2010 at 12:15 AM, Ronald S. Bultje <rsbultje at gmail.com>wrote:

> Hi Zhentan,
> On Tue, Aug 3, 2010 at 11:49 AM, zhentan feng <spyfeng at gmail.com> wrote:
> > #1 patch is extracted common code from mmst.c into mms.c and mms.h to be
> > used by mmsh.c
> - MMSContext should be embedded in MMSTContext, it shouldn't be a
> pointer as it is now. If you need a pointer, use &mmst->mms.
> - don't call the variable (in functions) mmst_ctx. Just mmst is fine.
> We know it's a context from the type. If you call it mms, you get the
> added benefit of not having to change each function call and function
> header, so I'd go for that.
> - There is no reason why you would move the definition in mmst.c,
> right now you're moving it, causing every line within MMS.Context to
> appear in the diff. There is no reason for this.

#4 patch extract common fields from MMSTContext into  MMSContext for the
later patch for mmsh.c
#5 is for vertical alignment
Best wishes~
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 4_extract_common_fields.patch
Type: application/octet-stream
Size: 18228 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100807/1c33ac59/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 5_vertical_align.patch
Type: application/octet-stream
Size: 1031 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100807/1c33ac59/attachment-0001.obj>

More information about the ffmpeg-devel mailing list