[FFmpeg-devel] [PATCH] FLAC parser

[Justin Ruggles]

Hi,

Michael Chinen wrote:

> On Thu, Aug 5, 2010 at 2:01 AM, Justin Ruggles <justin.ruggles at gmail.com> wrote:
>>> +            if (child_score + header->max_score > header->max_score) {
>>> +                /* keep the child because the frame scoring is dynamic */
>>> +                header->best_child = child;
>>> +                header->max_score  = FLAC_HEADER_BASE_SCORE + child_score;
>>> +            }
>>
>> This is the part that you changed and is now incorrect.  Previously, it was:
>> if (child_score + FLAC_HEADER_BASE_SCORE > header->max_score)
> I have the patch mostly ready but this time I'll look over it a bit
> more and test to save embarrassing bugs like this one.  Also I didn't
> get any log messages for that as I would expect so I want to make sure
> everything is right.  Just out of curiousity how are you testing it to
> find this out?

I tested on a sample I have that is about 30 min long.  It's basically
just 5 songs of different genres concatenated together.  It gave 3 or 4
log messages about multiple frames in a packet.

> I'll also change to 10 min headers and 3 consecutive after verifying
> on the minimal set of FLAC I have with me (not at my home setup.)
> Probably will submit something around 12 hours from now, after sanity
> testing is done.

10 and 3 worked fine for all the FLAC files in my collection.

Thanks,
Justin