[FFmpeg-devel] [FFmpeg-soc] [PATCH] Separate video specific BufferRef properties into VideoProps

S.N. Hemanth Meenakshisundaram smeenaks
Wed Aug 4 16:37:33 CEST 2010


On 08/03/2010 12:44 PM, Stefano Sabatini wrote:
> On date Tuesday 2010-08-03 00:07:55 -0700, S.N. Hemanth Meenakshisundaram encoded:
>   
>
> GET_BUFREF_VIDEO_PROPS -> more informative
>   

Done.
> possibly avoid the use of macros used just once, they tend just to
> obfuscate code.
>
>   

Removed

>
>> -                ff_get_plane_bytewidth(link->format, link->cur_buf->w, i);
>> +                ff_get_plane_bytewidth(link->format, cur_buf_props->w, i);
>>     
> note: this function should be moved to lavcore (and maybe cleaned up
> using pixdescs).
>   

Will do this in a separate patch.

>
> This can be outlined in a more readable way:
>
>     // copy common props
>     dst->pts                   = src->pts;
>     dst->pos                   = src->pos;
>
>     switch (src->type) {
>     VIDEO:
>     {
>        AVFilterBufferRefVideoProps *src_props, *dst_props;
>        AVFILTER_GET_REF_VIDEO_PROPS(src_props, src);
>        AVFILTER_GET_REF_VIDEO_PROPS(dst_props, dst);
>        *dst_props = *src_props;
>     }
>   

Changed as suggested.

>> diff --git a/libavfilter/vf_drawbox.c b/libavfilter/vf_drawbox.c
>>     
> Post patches against latest SVN, otherwise that will be more work for
> the committer. I'll fix the other filters in soc as I'll update it.
>
>
>   

This patch is now against latest SVN and passes lavfitest.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Separate-video-specific-BufferRef-properties-into-Vi.patch
Type: text/x-patch
Size: 18501 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100804/22cb7ff0/attachment.bin>



More information about the ffmpeg-devel mailing list