[FFmpeg-devel] [PATCH] vp8: don't store intra-pred modes into a full plane...

Jason Garrett-Glaser darkshikari
Mon Aug 2 03:30:18 CEST 2010


On Sun, Aug 1, 2010 at 6:27 PM, David Conrad <lessen42 at gmail.com> wrote:
> On Aug 1, 2010, at 6:04 PM, Pascal Massimino <pascal.massimino at gmail.com>
> wrote:
>
>> .. but just boundaries, for keyframes.
>
>> @@ -1534,6 +1531,7 @@
>> ? ? ? ? };
>>
>> ? ? ? ? memset(s->left_nnz, 0, sizeof(s->left_nnz));
>> + ? ? ? ?memset(s->intra4x4_pred_mode_left, DC_PRED,
>> sizeof(s->intra4x4_pred_mode_left));
>
> AV_WNA32(DC_PRED*0x01010101)
>
> Except that ok

As I explained on IRC, this makes things worse for P-frames, improving
I-frames is not very useful IMO.  It's fine, but any patch has to
avoid hurting P-frames.

Dark Shikari



More information about the ffmpeg-devel mailing list