[FFmpeg-devel] [PATCH] FLAC parser

Michael Chinen mchinen
Sun Aug 1 06:36:06 CEST 2010


Hi,

Thanks Justin and Diego, these were good suggestions, and I've put
them all in, attached here (don't forget to apply the original second
patch if you are testing on ffplay.)

On Fri, Jul 30, 2010 at 8:55 AM, Diego Biurrun <diego at biurrun.de> wrote:
>> --- a/libavcodec/flacdec.c
>> +++ b/libavcodec/flacdec.c
>> @@ -26,7 +26,7 @@
>> ? *
>> ? * For more information on the FLAC format, visit:
>> ? * ?http://flac.sourceforge.net/
>> - *
>> +v *
>
> oops..
>
> Never forget to compile the code you submit :)
but I don't want to give the impression that I don't compile before
submitting.  This was in a comment block :)

I looked over the code a few times to fix style, but I'm not confident
that I'm not missing things.  Please bear with me on this and let me
know what needs to be made nice.  Both my fingers and eyes are still
getting used to this style.

Best,

Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-FLAC-parser.patch
Type: application/octet-stream
Size: 37268 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100801/9bc1a8d9/attachment.obj>



More information about the ffmpeg-devel mailing list