[FFmpeg-devel] [PATCH 4/4] Implement ffserver generic metadata settings in the stream.

[Aurelien Jacobs]

On Sat, Apr 24, 2010 at 03:31:00PM +0200, Stefano Sabatini wrote:
> On date Tuesday 2010-04-13 00:39:27 +0200, Stefano Sabatini encoded:
> > On date Tuesday 2010-04-13 00:25:48 +0200, Aurelien Jacobs encoded:
> > > On Sun, Apr 11, 2010 at 08:36:22PM +0200, Stefano Sabatini wrote:
> > > > This patch is absolutely untested, if someone wants to try it and report back
> > > > that's fine, otherwise maybe I'll do it myself but who can say.
> > > > 
> > > > Regards.
> > > > 
> > > > ---
> > > >  ffserver.c |   20 ++++++++++++++++++++
> > > >  1 files changed, 20 insertions(+), 0 deletions(-)
> > > > 
> > > > diff --git a/ffserver.c b/ffserver.c
> > > > index 4404511..7b60517 100644
> > > > --- a/ffserver.c
> > > > +++ b/ffserver.c
> > > > [...]
> > > > +                else {
> > > > +                    *mid++= 0;
> > > > +                    stream->metadata = av_realloc(stream->metadata,
> > > > +                                                  sizeof(*stream->metadata) * (++stream->metadata_count));
> > > > +                    stream->metadata[stream->metadata_count-1].key  = av_strdup(arg);
> > > > +                    stream->metadata[stream->metadata_count-1].value= av_strdup(mid);
> > > > +                }
> > > > +            }
> > > 
> > > Looks like you are re-implementing av_metadata_set2()...
> > 
> > Ehm I copypasted that code from ffmpeg.c...
> 
> Updated.

Usage of metadata API seems OK in this patch.

> From 74e5925e0a0437b6bd9c2c051a0c0e58865a5e56 Mon Sep 17 00:00:00 2001
> From: Stefano Sabatini <stefano.sabatini-lala at poste.it>
> Date: Sun, 11 Apr 2010 20:20:23 +0200
> Subject: [PATCH 2/4] Implement ffserver generic metadata setting in the stream.
> 

> Also disable the use of the deprecated fields of AVFormatContext title,
> author, copyright, comment and album at the next libavformat major
> bump.

It seems that what you disable is not the use of deprecated fields of
AVFormatContext. It is the use of the "Title", "Author", etc options
in the ffserver config files. I have no strong opinion about deprecating
those or not, but at least, I see no reason to relate this to
libavformat major. It will still work after a libavformat major bump,
and it could be removed before libavformat major bump.
So to be clear, the #if LIBAVFORMAT_VERSION_MAJOR < 53 look wrong to me.

Anyway, I will let final approval to ffserver maintainer.

Aurel