[FFmpeg-devel] [PATCH] add some av_unused attributes

[Måns Rullgård]

Daniel Kristjansson <danielk at cuymedia.net> writes:

> On Wed, 2010-04-28 at 19:07 +0100, M?ns Rullg?rd wrote:
>> Daniel Kristjansson <danielk at cuymedia.net> writes:
>> 
>> > Some av_always_inline functions can cause chaff in the gcc warnings
>> > because they aren't used in every c file that includes the header
>> > they are in. This patch also adds "av_unused" to those six functions.
>> 
>> This looks wrong.  The compiler shouldn't warn about inline functions
>> being unused.  Did you do something unusual?
>> 
>
> This happens when compiling MythTV's version of ffmpeg, we compile with
> "-Wall -Wdisabled-optimization -Wredunant-decls -Wundef". I've been
> trying to clean up the MythTV version and submit our patches upstream
> so we can hopefully avoid using a patched version downstream at some
> point. I didn't realize this didn't affect upstream compiles (which do
> have many warnings, at least when I compile them.)

We use those warning flags and more, so it must be something else
you're doing that causes them.  Is av_always_inline perhaps not being
defined properly?

> In MythTV we track warnings and try to avoid code that introduces
> new ones: http://www.cuymedia.net/mythtv-warnings

Most of us try to avoid warnings too.  Unfortunately, Michael totally
ignores them, and refuses to listen to reason.

-- 
M?ns Rullg?rd
mans at mansr.com