[FFmpeg-devel] [PATCH 2/6] Implement IOCTL_ERROR macro and use it.

[Michael Niedermayer]

On Mon, Apr 26, 2010 at 12:36:12AM +0200, Luca Abeni wrote:
> On Mon, 2010-04-26 at 00:26 +0200, Michael Niedermayer wrote:
> [...]
> > > > > I am not sure if this kind of changes really improve the readability.
> > > > 
> > > > I generalized the previous patch, now we have a log_errno() function
> > > > which is used whenever we need to print the string corresponding to an
> > > > errno.
> > > 
> > > If we really want to have a log_errno(), then I think it should not be
> > > private to v4l2.c (I expect that libav* contains some other code that
> > > want to print error messages followed by an errno description).
> > > 
> > > I suspect it could go to libavutil/log.c... If Michael approves it, then
> > > I am ok with the av_log() -> log_errno() contained in this patch.
> > 
> > you are trying to sidestep saying the patch is uhm by pushing it my
> > direction?
> 
> No, sorry... :)
> I wanted to say that _if_ we want this kind of change, then log_errno()
> should not be a v4l2.c feature. But since I do not maintain log.c, I
> cannot approve putting log_errno() there.
> 
> So, I think there are various questions:
> 1) Is log_errno() useful/wanted? I am undecided about this (other
> people's opinions are welcome)

iam leaning toward no here

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I hate to see young programmers poisoned by the kind of thinking
Ulrich Drepper puts forward since it is simply too narrow -- Roman Shaposhnik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100426/71d533a4/attachment.pgp>