[FFmpeg-devel] [PATCH] add colours to warnings and errors

[François Revol]

Le Fri, 23 Apr 2010 02:36:10 +0200, Michael Niedermayer a ?crit :
> On Thu, Apr 22, 2010 at 08:06:27PM +0100, M?ns Rullg?rd wrote:
> > Michael Niedermayer <michaelni at gmx.at> writes:
> > 
> > > On Thu, Apr 22, 2010 at 02:14:32PM +0200, James Darnley wrote:
> > >> If you can't query the background colour, then I am going to 
> > > > assume it
> > >> is black.  If your terminal isn't then you need to fix it.  This 
> > > > is
> > >> looking more and more like a Windows only feature.
> > >> 
> > >> Yuvi suggested that I not set the bg and that I use 1 instead.  
> > > > For
> > >> him this sets bold, for me it sets bright colours.  So then 
> > > > there
> > >> could be a terminal which has a white bg but then sets bright 
> > > > colours.
> > >> 
> > >> Anyway, you guys thought it was ugly before...
> > >
> > > your patch is ugly still :)
> > >
> > > anyway, ive implemented it for ANSI now,
> > 
> > Thanks for breaking the display on millions of consoles.  You 
> > really
> > need to learn how to listen to arguments other than your own.
> 
> your argument was about yellow on white, i tested it and found yellow
> without the intensity/bold bit set quite readable even on white.
> 
> The actual breakage due to some terminals messing up with with ANSI 
> codes
> wasnt predicted as far as i remember. Either way the code is disabled
> until we have a better way to detect ANSI support.

The actual breackage is due to someone not using termcap/terminfo to 
retrieve the codes depending on $TERM as I already said.

Fran?ois.