[FFmpeg-devel] [PATCH 2/2] Autodetect pthreads

Jason Garrett-Glaser darkshikari
Mon Apr 19 19:43:49 CEST 2010


2010/4/19 M?ns Rullg?rd <mans at mansr.com>:
> David Conrad <lessen42 at gmail.com> writes:
>
>> On Apr 19, 2010, at 9:01 AM, M?ns Rullg?rd wrote:
>>
>>> David Conrad <lessen42 at gmail.com> writes:
>>>
>>>> ? ?Autoenable pthreads for libx264
>>>>
>>>> diff --git a/configure b/configure
>>>> index 959d63b..d2ec4c1 100755
>>>> --- a/configure
>>>> +++ b/configure
>>>> @@ -2579,6 +2579,11 @@ pthreads_if_any='
>>>> ? ? mpeg2video_encoder
>>>> '
>>>>
>>>> +# autoenable pthreads if the external lib is likely to depend on them
>>>> +if ! disabled pthreads; then
>>>> + ? ?enabled libx264 && enable pthreads
>>>> +fi
>>>
>>> This will break if any other threading lib is selected.
>>
>> Oops
>
> Seriously, this is getting uglier each time. ?What exactly are you
> trying to achieve?

Currently, if a user compiles with --enable-libx264 without
--enable-pthreads, ffmpeg will break.

This is stupid suboptimal behavior.  Furthermore, there is no reason
ffmpeg shouldn't have pthreads by default, just as it compiles with
zlib by default.

Dark Shikari



More information about the ffmpeg-devel mailing list