[FFmpeg-devel] [PATCH] split off h264_mb.h from h264.h

Michael Niedermayer michaelni
Wed Apr 14 02:42:24 CEST 2010

On Wed, Apr 14, 2010 at 01:05:40AM +0200, Diego Biurrun wrote:
> This patch splits off a separate header file for decode_mb_skip() and
> friends from h264.h.  I consider it a sensible idea in general and it
> eliminates more of those pesky 'defined but not used' warnings.
> Since this just moves static functions like my previous patch I assume
> it is similarly safe.  OK to apply?
> Diego

>  h264.h       |  541 -------------------------------------------
>  h264_cabac.c |    1 
>  h264_cavlc.c |    1 
>  h264_mb.h    |  735 -----------------------------------------------------------

iam against this patch. The placement of code into files becomes random
with it and merely guided by avoidance of silly warnings
these warnings should be disabled!

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No human being will ever know the Truth, for even if they happen to say it
by chance, they would not even known they had done so. -- Xenophanes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100414/f8bbf626/attachment.pgp>

More information about the ffmpeg-devel mailing list