[FFmpeg-devel] [PATCH] don't override file duration with bitrate guessed duration

elupus elupus
Tue Apr 13 00:13:17 CEST 2010


On Mon, 12 Apr 2010 15:37:00 +0000 (UTC), Carl Eugen Hoyos wrote:

> Joakim Plate <elupus <at> ecce.se> writes:
> 
>> [6 quoted lines suppressed]
> 
> Of course, but since the shown duration does not change, I wonder what the
> correct description of the patch is.
> 
> Carl Eugen

Ah, i hadn't noticed that in av_estimate_timings_from_bit_rate it doesn't
actually do anything when avfmt->duration had been set already. 

It even skips filling in the stream durations in that case, which leads to
no stream actually getting any duration

So in effect the patch makes sure fill_all_stream_timings get's called
which makes sure all streams have durations aswell as the full file.

Joakim




More information about the ffmpeg-devel mailing list