[FFmpeg-devel] [PATCH] move fill_filter_caches() to h264.c

Alexander Strange astrange
Mon Apr 12 19:10:20 CEST 2010


On Apr 12, 2010, at 11:13 AM, Diego Biurrun wrote:

> On Mon, Apr 12, 2010 at 04:13:46PM +0200, Michael Niedermayer wrote:
>> On Mon, Apr 12, 2010 at 10:01:01AM +0200, Diego Biurrun wrote:
>>> $subject: fill_filter_caches() is only used in h264.c.  Moving it
>>> to that file is sensible and eliminates at least a half dozen
>>> annoying 'defined but not used' warnings.
>> 
>>> h264.c |  216 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>> h264.h |  216 -----------------------------------------------------------------
>>> 2 files changed, 216 insertions(+), 216 deletions(-)
>>> 5b54f8efddf871e564c6d24c7c3aa280afc2730a  fill_filter_caches.diff
>> 
>> ok if the generated code does not change, and might even be ok if it
>> does change but in that case iam curious why it does
> 
> How do I best verify this?  All md5sums of libavcodec/h264*.o changed,
> as did some sizes (on my PowerBook G4, OS X 10.5, gcc 4.2).
> 
> Diego

Copy-paste the compile command, take out -g, and use -S, then diff the old and new .s files and ignore anything that's just random name changes.



More information about the ffmpeg-devel mailing list