[FFmpeg-devel] [PATCH] RTMP seek support

Michael Niedermayer michaelni
Mon Apr 12 17:32:14 CEST 2010

On Mon, Apr 12, 2010 at 08:27:32AM -0700, Howard Chu wrote:
> Michael Niedermayer wrote:
>> On Sun, Apr 11, 2010 at 04:40:06PM -0700, Howard Chu wrote:
>>> Instead of these magical conventions that aren't at all obvious from
>>> reading the code or its documentation, why not use:
>>>    current_ts, target_ts, flag.
>>> For exact seek you can still use current_ts = INT64_MIN as a special case
>>> but otherwise you drop one useless parameter.
>> an application might prefer to do seeking with all 3 timestamps different,
>> above where just examples.
> OK.
> We've gotten sidetracked anyway. So one more time with this patch. To 
> actually implement flv_read_seek2 correctly, there would need to be some 
> corresponding av_url_read_fseek2() function to propagate these timestamps 
> down to the ByteIOContext and URLContext. Since there is no such API at the 
> moment, there's not much more I can do with this.

you could add such api ;)

anyway that patch looks ok given it works and passes tests

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Opposition brings concord. Out of discord comes the fairest harmony.
-- Heraclitus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100412/db248f86/attachment.pgp>

More information about the ffmpeg-devel mailing list