[FFmpeg-devel] [PATCH 4/6] Rename ff_eval_free() to av_free_expr().

Stefano Sabatini stefano.sabatini-lala
Sun Apr 11 13:47:15 CEST 2010


On date Sunday 2010-04-11 00:30:46 +0200, Michael Niedermayer encoded:
> On Sat, Apr 10, 2010 at 11:51:21PM +0200, Stefano Sabatini wrote:
> > On date Saturday 2010-04-10 23:13:04 +0200, Michael Niedermayer encoded:
> > > On Sat, Apr 10, 2010 at 01:50:31PM +0200, Stefano Sabatini wrote:
> > > > ---
> > > >  libavcodec/eval.c        |   18 +++++++++---------
> > > >  libavcodec/eval.h        |    5 +++--
> > > >  libavcodec/ratecontrol.c |    2 +-
> > > >  3 files changed, 13 insertions(+), 12 deletions(-)
> > > > 
> > > > diff --git a/libavcodec/eval.c b/libavcodec/eval.c
> > > > index ce1f69a..dad689b 100644
> > > > --- a/libavcodec/eval.c
> > > > +++ b/libavcodec/eval.c
> > > > @@ -173,10 +173,10 @@ static double eval_expr(Parser * p, AVExpr * e) {
> > > >  
> > > >  static AVExpr * parse_expr(Parser *p);
> > > >  
> > > > -void ff_eval_free(AVExpr * e) {
> > > > +void av_free_expr(AVExpr * e) {
> > > 
> > > renaming to av_ means making the function public, it makes no sense to make
> > > just the deallocation function public
> > 
> > What about to rename the functions using ff_ prefixes (ff_free_expr()
> > in this case)?
> 
> ff_free_expr() is ok

Applied.
-- 
FFmpeg = Fiendish Foolish Majestic Philosofic Elitist God



More information about the ffmpeg-devel mailing list