[FFmpeg-devel] [RFC] eval API review

[Víctor Paesa]

Hi,

On Fri, Apr 2, 2010 at 6:58 PM, Ronald S. Bultjewrote:
> Hi,
>
> On Fri, Apr 2, 2010 at 12:32 PM, Stefano Sabatini wrote:
>> Michael also mentioned that he wanted to review the API before to make
>> it public, follows an attempt at it.
>
> In several places, the string "identifers" occurs. This should be "identifiers".

There is a "doube" that sould be "double".

> The API is undoubtedly very powerful, but I have no idea what it does.
> I'd write a sample chunk of code and put it in the comments. Without
> that, I have no idea what I'd use this for or what to review it for.
> I'd just say it looks very complex.

There are a few usage examples:

libavcodec/eval.c contains a small test/usage example.

libavcodec/ratecontrol.c contains the original usage of this API.

vf_setpts.c in libavfilter SoC and vf_overlay.c in libavfilter FFmpeg
are probably more easier to read examples of eval API.

Stefeno made vf_eval.c that is somewhere in the maillist archive.

Besides pointers to the examples, I think that eval.h should also
point to the list of available funtions at
http://www.ffmpeg.org/ffmpeg-doc.html#SEC18

Regards,
V?ctor