[FFmpeg-devel] [PATCH] Add support to AVSEEK_SIZE to the file protocol seek callback

Stefano Sabatini stefano.sabatini-lala
Fri Apr 2 13:42:31 CEST 2010


On date Friday 2010-04-02 13:15:51 +0200, Stefano Sabatini encoded:
> On date Friday 2010-04-02 13:13:27 +0200, Stefano Sabatini encoded:
> > Hi, as in subject.
> > 
> > I'm not sure about the way I enabled the use of the fstat/fopen64
> > variants.
> 
> Discard this comment, it was related to a previous version, when
> large file support is enabled both fstat and fopen should work as
> their 64 versions, from GNU libc manual:
> |     When the sources are compiled with `_FILE_OFFSET_BITS == 64' this
> |     function is in fact `stat64' since the LFS interface transparently
> |     replaces the normal implementation.

BTW what's the point of the comment:
/* XXX: use llseek */
?

(It's there since the initial revision.)

OK to remove it?
-- 
FFmpeg = Fundamentalist & Friendly Mastering Puritan Elaborated Gorilla



More information about the ffmpeg-devel mailing list