[FFmpeg-devel] [PATCH] RTMP seek support

Howard Chu hyc
Thu Apr 1 02:24:49 CEST 2010

Howard Chu wrote:
> Michael Niedermayer wrote:
>> On Tue, Mar 30, 2010 at 06:42:50PM -0700, Howard Chu wrote:
>>>> Note that the did_rseek flag wouldn't even be needed if the rest of flvdec
>>>> always read from the start of a frame, instead of reading from the end of
>>>> the previous frame, as it currently does.
>> putting the url_fskip() inside the loop at the end seems cleaner to me
>> also the url_fskip() movement could be a seperate patch
> OK, patch separated, url_fskip() moved to inside the loop.

The rest of the patch.

 >> removial is planed but the new API might be changed if we find the need
 >> to change it still ...

It seems to me that one thing that ought to be changed is that rescaling the 
timestamp should still be done by the caller, not in read_seek2. Right now 
each implementation of read_seek2() has to duplicate this code.

   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: difseek.txt
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100331/3559c01a/attachment.txt>

More information about the ffmpeg-devel mailing list