[FFmpeg-devel] [PATCH] use MANGLE in cavsdsp_mmx.c

Uoti Urpala uoti.urpala
Wed Sep 30 18:17:33 CEST 2009


On Wed, 2009-09-30 at 17:59 +0200, Reimar D?ffinger wrote:
> since OpenBSD uses PIC and EBP and EBX can't be used, it can't compile cavsdsp_mmx.c.
> While those are "m" constraints, at least some still use up a register.
> Attached is a patch that fixes compilation by using MANGLE on one of the
> variables that is only used in 2 places.
> Personally I'd be in favour to be consistent with other parts of FFmpeg
> and just use MANGLE whereever possible, but that would be a more
> invasive change.

In what sense does it "use PIC" if MANGLE works? MANGLE is only an
uglier and less robust way to get the same effect as you'd get by
compiling without -fPIC. So does the default compiler always force -fPIC
on, even though binaries compiled without that do work fine on the
platform? Or what?




More information about the ffmpeg-devel mailing list