[FFmpeg-devel] [PATCH] remove rounding-up for put_bits_count in vorbis_enc

Reimar Döffinger Reimar.Doeffinger
Wed Sep 30 12:44:05 CEST 2009


Hello,
flush_put_bits aligns the bitstream, so IMO adding 7 to put_bits_count is
useless and clutters the code.
Index: vorbis_enc.c
===================================================================
--- vorbis_enc.c        (revision 20095)
+++ vorbis_enc.c        (working copy)
@@ -542,7 +542,7 @@
     put_bits(&pb,  1, 1); // framing
 
     flush_put_bits(&pb);
-    hlens[0] = (put_bits_count(&pb) + 7) / 8;
+    hlens[0] = put_bits_count(&pb) >> 3;
     buffer_len -= hlens[0];
     p += hlens[0];
 
@@ -555,7 +555,7 @@
     put_bits(&pb,  1, 1); // framing
 
     flush_put_bits(&pb);
-    hlens[1] = (put_bits_count(&pb) + 7) / 8;
+    hlens[1] = put_bits_count(&pb) >> 3;
     buffer_len -= hlens[1];
     p += hlens[1];
 
@@ -628,7 +628,7 @@
     put_bits(&pb, 1, 1); // framing
 
     flush_put_bits(&pb);
-    hlens[2] = (put_bits_count(&pb) + 7) / 8;
+    hlens[2] = put_bits_count(&pb) >> 3;
 
     len = hlens[0] + hlens[1] + hlens[2];
     p = *out = av_mallocz(64 + len + len/255);
@@ -1023,7 +1023,7 @@
     avccontext->coded_frame->pts = venc->sample_count;
     venc->sample_count += avccontext->frame_size;
     flush_put_bits(&pb);
-    return (put_bits_count(&pb) + 7) / 8;
+    return put_bits_count(&pb) >> 3;
 }
 
 




More information about the ffmpeg-devel mailing list